Skip to content

MNT Use full flake8 rather than flake8_diff.sh #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 9, 2023
Merged

MNT Use full flake8 rather than flake8_diff.sh #1415

merged 8 commits into from
Apr 9, 2023

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Apr 8, 2023

Easier to understand, easier to run locally, flake8 --diff has been removed in flake8>=6 see #1383. There are not that many flake8 violations to fix.

tomMoral
tomMoral approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice idea so it will be easier to maintain in the long run.
A couple of comments but otherwise LGTM

lesteve and others added 2 commits April 8, 2023 10:07
@lesteve
Fix
1ad4b0c
@lesteve @tomMoral
Update joblib/test/test_memory.py
1cc0279 
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
tomMoral
tomMoral reviewed Apr 8, 2023
View reviewed changes
Copy link
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more typo

tomMoral
tomMoral reviewed Apr 8, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 8, 2023 •
edited
Loading

Codecov Report

Patch coverage: 80.76% and project coverage change: -0.09 ⚠️

Comparison is base (a007d79) 94.87% compared to head (fd1dd6c) 94.78%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
- Coverage   94.87%   94.78%   -0.09%     
==========================================
  Files          46       45       -1     
  Lines        6901     6889      -12     
==========================================
- Hits         6547     6530      -17     
- Misses        354      359       +5
Impacted Files Coverage Δ
joblib/__init__.py 100.00% <ø> (ø)
joblib/executor.py 100.00% <ø> (ø)
joblib/memory.py 95.52% <0.00%> (+0.26%) ⬆️
joblib/numpy_pickle_compat.py 91.08% <ø> (ø)
joblib/test/test_func_inspect_special_encoding.py 50.00% <ø> (ø)
joblib/test/test_hashing.py 99.06% <ø> (-0.01%) ⬇️
joblib/test/test_numpy_pickle_compat.py 100.00% <ø> (ø)
joblib/test/test_numpy_pickle_utils.py 100.00% <ø> (ø)
joblib/test/test_parallel.py 97.13% <ø> (-0.01%) ⬇️
joblib/logger.py 86.84% <25.00%> (ø)
... and 6 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

tomMoral
tomMoral approved these changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the failure does not seem related.
Merging and hoping this won't cause too much troubles with other PRs.

@tomMoral tomMoral merged commit 253a446 into joblib:master Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomMoral tomMoral tomMoral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesteve @tomMoral