-
Notifications
You must be signed in to change notification settings - Fork 432
MNT Use faulthandler rather than custom autokill logic #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming greenish CI, +1 on my side :)
Codecov ReportBase: 93.88% // Head: 93.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
+ Coverage 93.88% 93.97% +0.09%
==========================================
Files 52 52
Lines 7342 7319 -23
==========================================
- Hits 6893 6878 -15
+ Misses 449 441 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with this comment.
This reverts commit c184397.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thx @lesteve
This should give more information in case of deadlock.