Skip to content

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Aug 22, 2018

This PR increase significantly the dataset size used in the compressor comparison example. Now durations measured are more realistic and are more inline with the example conclusions.

This PR follows the conclusions provided in this comment.

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #753 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage    95.4%   94.76%   -0.65%     
==========================================
  Files          43       43              
  Lines        6160     6300     +140     
==========================================
+ Hits         5877     5970      +93     
- Misses        283      330      +47
Impacted Files Coverage Δ
joblib/backports.py 39.58% <0%> (-56.26%) ⬇️
joblib/disk.py 80% <0%> (-8.34%) ⬇️
joblib/test/test_store_backends.py 91.17% <0%> (-5.89%) ⬇️
joblib/pool.py 87.93% <0%> (-3.45%) ⬇️
joblib/test/common.py 86.44% <0%> (-1.7%) ⬇️
joblib/logger.py 85.52% <0%> (-1.32%) ⬇️
joblib/func_inspect.py 93.75% <0%> (-1.14%) ⬇️
joblib/test/test_parallel.py 96.43% <0%> (-0.6%) ⬇️
joblib/_store_backends.py 89.94% <0%> (-0.53%) ⬇️
joblib/test/test_memmapping.py 99.7% <0%> (-0.3%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce40a7...66951bb. Read the comment docs.

@aabadie
Copy link
Contributor Author

aabadie commented Aug 22, 2018

The CI is green and the builds seem stable on RTD. Let's merge.

@aabadie aabadie merged commit 3c19bf5 into master Aug 22, 2018
@aabadie aabadie deleted the rtd_improve_mem branch August 22, 2018 13:22
yarikoptic added a commit to yarikoptic/joblib that referenced this pull request Sep 4, 2018
* tag '0.12.3': (23 commits)
  Release 0.12.3
  Loky 2.2.1 (joblib#760)
  FIX: FileSystemStoreBackend string representation only returning location (path) (joblib#765)
  Add optional dependency on psutil
  MAINT remove brittle time based assertion in test (joblib#761)
  Fix a bug in nesting level computation with FallbackToBackend(SequentialBackend()) (joblib#759)
  Make docstring more consistent with project style
  Improved performance of call_and_shelve (joblib#757)
  Better test name
  Fix default context handling (joblib#754)
  cloudpickle 0.5.5 (joblib#756)
  Fixed error where filter args was consuming kwargs (joblib#750)
  FIX pickle roundtrip for Memory and related classes. (joblib#746)
  test that passes but timeout appveyor because of unclosed semaphore tracker (joblib#676)
  DOC: fine tune compressor example dataset size for ReadTheDocs (joblib#753)
  FIX: MemorizedResult not picklable (joblib#752)
  [MRG] Better message with py27 when lz4 is not installed (joblib#740)
  MNT remove mutable default value for backend_options parameter (joblib#748)
  MNT create test file for _store_backends module (joblib#749)
  DOC consistently use memory rather than mem in memory.rst (joblib#744)
  ...
yarikoptic added a commit to yarikoptic/joblib that referenced this pull request Sep 4, 2018
* releases: (23 commits)
  Release 0.12.3
  Loky 2.2.1 (joblib#760)
  FIX: FileSystemStoreBackend string representation only returning location (path) (joblib#765)
  Add optional dependency on psutil
  MAINT remove brittle time based assertion in test (joblib#761)
  Fix a bug in nesting level computation with FallbackToBackend(SequentialBackend()) (joblib#759)
  Make docstring more consistent with project style
  Improved performance of call_and_shelve (joblib#757)
  Better test name
  Fix default context handling (joblib#754)
  cloudpickle 0.5.5 (joblib#756)
  Fixed error where filter args was consuming kwargs (joblib#750)
  FIX pickle roundtrip for Memory and related classes. (joblib#746)
  test that passes but timeout appveyor because of unclosed semaphore tracker (joblib#676)
  DOC: fine tune compressor example dataset size for ReadTheDocs (joblib#753)
  FIX: MemorizedResult not picklable (joblib#752)
  [MRG] Better message with py27 when lz4 is not installed (joblib#740)
  MNT remove mutable default value for backend_options parameter (joblib#748)
  MNT create test file for _store_backends module (joblib#749)
  DOC consistently use memory rather than mem in memory.rst (joblib#744)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant