Fix nested parallelism and dask auto-scatter #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
+ Coverage 95.23% 95.26% +0.03%
==========================================
Files 40 42 +2
Lines 5769 6103 +334
==========================================
+ Hits 5494 5814 +320
- Misses 275 289 +14
Continue to review full report at Codecov.
|
85e2a39 to
e58b3dc
Compare
…ween data scattering and nested calls
e58b3dc to
a363d40
Compare
|
Cool. I'm glad to see this move over. |
|
Should we be updating Distributed in light of this? Note this in Joblib as of version 0.12.2. |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Aug 22, 2018
* tag '0.12.2': Release 0.12.2 Pin numpy version for sklearn test (joblib#734) Loky 2.2.0 (joblib#733) [MRG] BatchedCalls backward compat (joblib#732) Better detection for the cloudpickle wrapper (joblib#726) DOC: attempt to fix the build on RTD (joblib#725) Include dask backend to fix nested parallelism and auto-scatter (joblib#722) FIX: re-establish argument_hash attribute for backward compat (joblib#716) Fix cachedir deprecation message (joblib#720)
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Aug 22, 2018
* releases: Release 0.12.2 Pin numpy version for sklearn test (joblib#734) Loky 2.2.0 (joblib#733) [MRG] BatchedCalls backward compat (joblib#732) Better detection for the cloudpickle wrapper (joblib#726) DOC: attempt to fix the build on RTD (joblib#725) Include dask backend to fix nested parallelism and auto-scatter (joblib#722) FIX: re-establish argument_hash attribute for backward compat (joblib#716) Fix cachedir deprecation message (joblib#720)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manual and auto-scattering of numpy arrays disabled nested parallelism. To fix it's much easier to include the code of the backend as part of joblib itself.