fix kwonlydefaults key error in filter_args #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks overall good, but the tests now are incompatible with python 2, and we still support python 2. |
|
would you like me to remove the changes to the tests and keep only the changes to filter_args? |
|
would you like me to remove the changes to the tests and keep only the changes to filter_args?
No, I'd like to keep the test. They are great. They just need to be
skipped under Python 2.
I realize that this is a bit difficult, because under Python 2 they are
creating a SyntaxError. Maybe a solution is to use eval / exec?
|
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
==========================================
- Coverage 95.07% 95.03% -0.05%
==========================================
Files 40 40
Lines 5751 5758 +7
==========================================
+ Hits 5468 5472 +4
- Misses 283 286 +3
Continue to review full report at Codecov.
|
3f214e6 to
7e36897
Compare
|
@GaelVaroquaux do you know why it fails the CircleCI test? I changed the extra test to run only under python 3. |
|
@GaelVaroquaux do you know why it fails the CircleCI test?
Not clear to me. Maybe it's just a random failure. I've restarted.
I changed the extra test to run only under python 3.
Beautiful! This looks good to me. Let's wait for CircleCI to complete,
and hopefully merge!
|
|
Circle ran without problem. I am merging. |
|
Thank you!! |
|
👍 |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Jul 28, 2018
* tag '0.12.1': Release 0.12.1 fix kwonlydefaults key error in filter_args (joblib#715) MNT fix some "undefined name" flake8 warnings (joblib#713). from importlib import reload for Python 3 (joblib#675) MTN vendor loky2.1.4 (joblib#708)
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Jul 28, 2018
* releases: (121 commits) Release 0.12.1 fix kwonlydefaults key error in filter_args (joblib#715) MNT fix some "undefined name" flake8 warnings (joblib#713). from importlib import reload for Python 3 (joblib#675) MTN vendor loky2.1.4 (joblib#708) Release 0.12 typo typo typo ENH add initializer limiting n_threads for C-libs (joblib#701) DOC better parallel docstring (joblib#704) [MRG] Nested parallel call thread bomb mitigation (joblib#700) MTN vendor loky2.1.3 (joblib#699) Make it possible to configure the reusable executor workers timeout (joblib#698) MAINT increase timeouts to make test more robust on travis DOC: use the .joblib extension instead of .pkl (joblib#697) [MRG] Fix exception handling in nested parallel calls (joblib#696) Fix skip test lz4 not installed (joblib#695) [MRG] numpy_pickle: several enhancements (joblib#626) Introduce Parallel.__call__ backend callbacks (joblib#689) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for key error which were thrown from filter_args when default values were not specified for kw only arguments.
For example, in the following case arg_spec.kwonlydefaults is None:
In another example, arg_spec.kwonlydefaults is not None, but it does not contain 'y':