Skip to content

Conversation

javuto
Copy link
Collaborator

@javuto javuto commented May 28, 2025

Very little python in this repository, so all the python pre-commit rules not needed and were creating issues. Refreshed the configuration to update versions and better golang rules.

@javuto javuto requested a review from Copilot May 28, 2025 09:21
@javuto javuto added 🧹 cleanup Cleanup related issues cicd CICD related issues labels May 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refresh the repository’s pre-commit configuration by removing unused Python hooks, bumping versions, and strengthening Go linting rules

  • Updated pre-commit-hooks to v5.0.0
  • Removed all Python-related repos (Black, Flake8, Pylint, etc.)
  • Bumped pre-commit-golang to v1.0.5 and enabled additional Go linters
Comments suppressed due to low confidence (1)

.pre-commit-config.yaml:30

  • The golangci-lint hook is declared twice—once with args and once without. Remove the duplicate entry (the one without args) to avoid configuration conflicts.
-      - id: golangci-lint # requires github.com/golangci/golangci-lint

@javuto javuto merged commit e21cc92 into main May 28, 2025
53 checks passed
@javuto javuto deleted the remove-python-pre-commit branch May 28, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd CICD related issues 🧹 cleanup Cleanup related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant