Change default inactive hours to be positive #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of inactive hours by ensuring it is a positive value and introduces dedicated constants for environment and platform selectors for consistency.
- Updated the documentation in utils.go to clarify that the inactive parameter is expected to be positive.
- Introduced EnvironmentSelector and PlatformSelector constants in nodes.go and replaced literal strings with these constants.
- Changed defaultInactive in admin/main.go from -72 to 72.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/nodes/utils.go | Updated documentation in the IsActive function to reflect the expectation of a positive inactive value. |
| pkg/nodes/nodes.go | Added constants for selectors and updated related function calls to use these constants. |
| cmd/admin/main.go | Modified the defaultInactive value to be positive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #640 to change the
defaultInactivefor Inactive Hours to be positive. Also adding a const for environment and platform selector.