Removing references to Debug Service or HTTP from all services #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes conditional DebugService and DebugHTTP calls from various services and replaces them with direct debug logging calls, streamlining the logging flow and updating some message formats. Key changes include:
- Removing DebugService conditionals from logging in TLS, API, and Admin packages.
- Consolidating and simplifying debug log messages.
- Removing unused debug-related settings in templates and admin handlers.
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cmd/tls/main.go | Replaced DebugService condition with direct debug logging. |
| cmd/api/settings.go | Simplified settings initialization by removing DebugService checks. |
| cmd/api/handlers/* | Updated all API handlers to use plain debug logging messages. |
| cmd/admin/* | Removed debug service conditions from administrative handlers. |
| cmd/admin/static/js/settings.js | Removed the unused changeDebug function. |
| cmd/admin/handlers/types-templates.go | Removed debug flags no longer in use. |
Files not reviewed (1)
- cmd/admin/templates/components/page-aside-right.html: Language not supported
Comments suppressed due to low confidence (1)
cmd/api/handlers/environments.go:183
- The log message format is missing a space after 'environment'. Consider updating it to "Returned data for environment %s : %s" to improve readability.
log.Debug().Msgf("Returned data for environment%s : %s", env.Name, returnData)
Better text formatting Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@zhuoyuan-liu please take a look, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all references for
debug_serviceanddebug_httpsettings and better debug messages.