Add prometheus metrics to osctrl-tls #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I will add some comments in a code review 🙂 |
javuto
reviewed
Oct 2, 2024
javuto
reviewed
Oct 2, 2024
javuto
reviewed
Oct 2, 2024
javuto
requested changes
Oct 2, 2024
|
I have updated the flag. Should I start to clean up the old metrics components for osctrl-tls? |
Merged
javuto
reviewed
Oct 8, 2024
You mean the emitted metrics? Instead of removing them, it would be better if we can find a way for those to be utilized by prometheus too. |
|
@javuto I have added the flag, could you please take another look? |
javuto
approved these changes
Oct 9, 2024
|
@javuto I Just fixed the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added Prometheus metrics support for osctrl-tls. Issue: #504
Currently, it has all default metrics go metrics such as memory info and gc duration etc. Also, we added one custom histogram metric to measure the total request/latency to each osquery endpoint.
The metric server would run as a separate service in a different port. We can query e.g. P90 latency for each endpoint with different environments with the histogram metric.
Also the request rate for different path and status code.
