Skip to content

Fix the default binds for a 'godror' driver #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2021
Merged

Fix the default binds for a 'godror' driver #731

merged 1 commit into from
May 15, 2021

Conversation

2403905
Copy link

@2403905 2403905 commented Apr 26, 2021 •
edited
Loading

Description
Fix for the issue for an oracle driver https://github.com/godror/godror

This code didn't work

        query, args, _ := sqlx.In('select * from user where id in (?)', idList)
        q := oracleDb.Rebind(query)
	err = oracleDb.SelectContext(ctx, &dtos, q, args...)
	if err != nil {
		return nil, err
	}

@jmoiron jmoiron merged commit e6cd7ae into jmoiron:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2403905 @jmoiron