Start acting on some of the things I have reported bugs on #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't make sense to support older python versions than the plugin host. Also everything before 3.9 is already end of lifed.
This allows 'watching_testrunner pytest' which runs the testsuite on save in the editor making the test -> feedback loop that much shorter.
Because the pyproject.toml does not specify a build system, uv assumes that it should not be installed. Not helpfull.
And remove obsoleted less precise code comments
|
Hi @dwt, thanks so much for your contributions! I really appreciate it. These changes look good to me! I don't ususally develop in Python, so these improvements are great :) |
This was referenced Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I had some cycles to burn, so I started thinking about how some of the findings I reported in #7 and #6.
What do you think?