fix: Make command execution order consistent in SystemRegistryImpl #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecute method This fixes issue jline#1232 by changing the order of command execution checking in the execute method to be consistent with other methods in the class. Now it checks custom registries first, then scripts, and finally local commands, which allows overriding built-in commands like 'exit' and 'clear' with custom implementations. Added a test that demonstrates the ability to override built-in commands with custom implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #1232 by making the command execution order consistent in the method.
Problem
In most methods in , the order of command execution checking is:
However, in the method, the order was different:
This inconsistency made it impossible to override built-in commands like "exit" and "clear" with custom implementations, as the local commands were always checked first in the method.
Solution
Modified the method to make the command execution order consistent with other methods in the class:
Testing
Added a test class that demonstrates the ability to override built-in commands with custom implementations. The test verifies that our fix works correctly.
Fixes #1232