Skip to content

perf: avoid update when expanding same node #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023

Conversation

jledentu
Copy link
Owner

@jledentu jledentu commented May 5, 2023

This PR early returns when update tries to expand the already expanded node

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9455989) 99.42% compared to head (3b6d894) 99.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x     #207   +/-   ##
=======================================
  Coverage   99.42%   99.43%           
=======================================
  Files           4        4           
  Lines         175      177    +2     
  Branches       44       45    +1     
=======================================
+ Hits          174      176    +2     
  Misses          1        1           
Impacted Files Coverage Δ
src/utils/tree-model.js 99.20% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jledentu jledentu merged commit 87b859e into 2.x May 5, 2023
github-actions bot pushed a commit that referenced this pull request May 5, 2023
## [2.1.2](v2.1.1...v2.1.2) (2023-05-05)

### Performance Improvements

* avoid update when expanding same node ([#207](#207)) ([87b859e](87b859e))
@github-actions
Copy link

github-actions bot commented May 5, 2023

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jledentu jledentu deleted the perf--avoid-update-when-expanding-same-node branch May 5, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant