Add ifdef to disable pthreads usage #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! I think it's not worth changing cmake for this, since interested users may just define the preprocessor symbol from their side if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I used nanoflann in my project and got a linker error because of pthreads usage (
std::async). Since I don't use parallel construction and don't want to link my code with pthreads, I've just removed these calls from the library. I think that it might be convenient for others to do the same by just adding a define before including the header, so I made this PR.I was thinking about adding the possibility to disable multi-threading to CMake, but I'm not an expert on it. If you think that it is necessary, I'll figure it out and add it to the PR.
Also, I've included in the readme all the ifdefs I found in the header.