added reading resolution info #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iikka Virkkunen <iikka@virkkuset.com>
|
Hi! nice addition, thanks. Could I ask you a favour: please rename TinyTIFFReader_GetResolutionUnit() to TinyTIFFReader_getResolutionUnit() (lower case g) Best, |
|
also please reference the constants in the getter function documentation |
|
finally, please set default values for the new struct members in TinyTIFFReader_getEmptyFrame() |
…n and added resolution fields to empty frame initialization
|
Thank you for the quick and positive response. I've now made the requested changes. Thank you for the constructive comments (and sorry I wasn't more careful to begin with). Iikka |
|
thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly simple patch to add read access to resolution information of a TIFF file. The relevant IFD entries were already in place, so this just
Although the resolution info is unimportant or not used in many applications, it does have high significance in certain special areas, such as industrial X-ray images, where TIFF data format is extensively used for the raw data. Thus, I'd kindly request you to implement reading the resolution information.