Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jjti/go-spancheck
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.3
Choose a base ref
...
head repository: jjti/go-spancheck
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.0
Choose a head ref
  • 3 commits
  • 10 files changed
  • 3 contributors

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    e803c7a View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Bump golang.org/x/tools

    jjti committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    41d395c View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Add support for "Start" utility methods (#16)

    * feat: replace hardcoded span start function names with regex patterns
    
    Replaces the hardcoded list of function names and packages with a list
    of regex patterns that may be extended using the
    `-extra-start-span-signatures` command line option.
    
    The format is `<regex>:<telemetry-type>`. Ideally this would just be a
    list of regex patterns, but we need to know what telemetry library we're
    matching so we don't run RecordError on opencensus.
    
    * tests: update tests to use new default config
    
    The tests need to unconditionally include the
    DefaultStartSpanSignatures, which was not possible with the old harness.
    
    Instead of returning an object directly, they now return a function to
    prepare a config, which ensures they all start out with the default
    config as a base.
    
    * Add test, skip validating spans within starter funcs
    
    * Hack: fix check for start func method name
    
    * fix: increase robustness of skipping custom matchers
    
    Instead of checking if the function name matches, which might result in
    overzealous exclusions, prefer to match against the function signature
    itself
    
    * docs: document new behaviour
    
    * Remove sig split in config
    
    * nit: small wording changes
    
    ---------
    
    Co-authored-by: josh <joshua.timmons1@gmail.com>
    trixnz and jjti authored Apr 21, 2024
    Configuration menu
    Copy the full SHA
    34d21b4 View commit details
    Browse the repository at this point in the history
Loading