Skip to content

Conversation

ipetkov
Copy link
Contributor

@ipetkov ipetkov commented Aug 17, 2025

Checklist

Fixes #5323

Only fetch refspecs matching a very conservative set of patterns (i.e. no branch or remote renames, must be a forced refspec for refs/heads/, etc) is supported and everything outside of that will be (warned about) and ignored. We can always expand these in the future but for now it would be good to avoid ambiguities about how branch renaming ought to be handled.

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes

@ipetkov
Copy link
Contributor Author

ipetkov commented Aug 17, 2025

Can't tell why the windows tests are failing (at first I assumed a line ending issue but that doesn't seem to be it).

I'll try to test this in a Windows VM when I can if no one can help me spot the issue before then

I was able to figure it out, git insists on Unix style separators even on windows and I found a gix helper function to handle that

@ipetkov ipetkov force-pushed the ivan/push-xsknkpvztrru branch from 7ee1af2 to 440eede Compare August 17, 2025 19:07
@ipetkov ipetkov force-pushed the ivan/push-xsknkpvztrru branch from 440eede to 3a044ec Compare August 21, 2025 00:51
@ipetkov ipetkov requested a review from yuja August 21, 2025 00:52
@ipetkov ipetkov force-pushed the ivan/push-xsknkpvztrru branch from 3a044ec to 902ccad Compare August 21, 2025 00:54
@ipetkov ipetkov force-pushed the ivan/push-xsknkpvztrru branch from 902ccad to e133af8 Compare August 22, 2025 23:08
@ipetkov ipetkov requested a review from yuja August 22, 2025 23:27
@ipetkov ipetkov force-pushed the ivan/push-xsknkpvztrru branch from e133af8 to 28ed0a7 Compare August 23, 2025 18:27
@ipetkov ipetkov requested a review from yuja August 23, 2025 18:28
This changes the behavior of git fetch to respect the fetch refspecs
configured on the remote. This is handy for projects which use
customized fetch refspecs (e.g. only fetch certain patterns, but not all
branches) but without having to remember and repeat all the patterns by
hand on the CLI

Fixes #5323
@ipetkov ipetkov force-pushed the ivan/push-xsknkpvztrru branch from 28ed0a7 to 38b2ef7 Compare August 24, 2025 16:55
@yuja yuja mentioned this pull request Aug 25, 2025
2 tasks
@ipetkov ipetkov added this pull request to the merge queue Aug 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 25, 2025
@ipetkov ipetkov added this pull request to the merge queue Aug 25, 2025
Merged via the queue into main with commit 75fa7de Aug 25, 2025
29 checks passed
@ipetkov ipetkov deleted the ivan/push-xsknkpvztrru branch August 25, 2025 16:06
ipetkov added a commit that referenced this pull request Sep 1, 2025
Now that #7275 it's worth mentioning
that simple fetch refspecs will (now) be respected when other branches
are otherwise not specified on the CLI
ipetkov added a commit that referenced this pull request Sep 1, 2025
Now that #7275 has merged it's worth
mentioning that simple fetch refspecs will (now) be respected when other
branches are otherwise not specified on the CLI
github-merge-queue bot pushed a commit that referenced this pull request Sep 1, 2025
Now that #7275 has merged it's worth
mentioning that simple fetch refspecs will (now) be respected when other
branches are otherwise not specified on the CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Honor remote refspec definitions when fetching from git colocated workspaces
3 participants