cli: fix fetching all tags during jj git clone
#7192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
17f8bfc to
daa4b40
Compare
jj git clone
jj git clonejj git clone
daa4b40 to
0c58d74
Compare
caa8008 to
43d7c13
Compare
By default `git clone` will fetch all tags on a remote (unless `--no-tags` is specified). Eventually we'll want to support the same behavior, though since we first configure a remote and then fetch, we'll need to configure the remote with the correct *general* tag fetching behavior, but still perform the first fetch with all tags included.
43d7c13 to
ee666f2
Compare
yuja
approved these changes
Aug 17, 2025
ee666f2 to
88cd649
Compare
By default, `git clone` will fetch all tags (same as `git clone --tags`), but since we perform a clone by creating a remote first then fetching it, we have to be a little smarter and keep track of when we're doing a clone so that we ensure all tags are fetched. `git clone --no-tags` will skip fetching tags at all, and so this is also the now the behavior of `jj git clone --fetch-tags none` Closes #4682
88cd649 to
11ac92c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes #4682
Stacked on top of #7175 so I'm going to keep this as a draft until that PR landsIf applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)