-
Notifications
You must be signed in to change notification settings - Fork 712
cli: support --fetch-tags
for jj git clone
and jj git remote add
#7175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
reviewed
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me, thanks!
8288e0d
to
056539d
Compare
4 tasks
056539d
to
620c685
Compare
yuja
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
In a future commit we'll add support for controlling a git remote's tag fetch behavior, which may result in a `tagOpt = --[no-]tags` entry in the remote configuration. Doing this change here means we will avoid incorrectly flagging remote configurations as unsupported.
620c685
to
501806c
Compare
--[no-]tags
for jj git clone
and jj git remote add
--fetch-tags
for jj git clone
and jj git remote add
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Git backend currently respects a remote's
tagOpt
configuration for all fetches, but in order to change the behavior away from the default, one has to manually edit.git/config
or drop down to Git to perform the change.To remedy this, this PR adds support for specifying
--tags
or--no-tags
forjj git clone
andjj git remote add
which mirrors the behavior ofgit clone
andgit remote add
, respectively.Checklist
If applicable:
CHANGELOG.md
README.md
,docs/
,demos/
)cli/src/config-schema.json
)