Skip to content

Conversation

ipetkov
Copy link
Contributor

@ipetkov ipetkov commented Aug 5, 2025

The Git backend currently respects a remote's tagOpt configuration for all fetches, but in order to change the behavior away from the default, one has to manually edit .git/config or drop down to Git to perform the change.

To remedy this, this PR adds support for specifying --tags or --no-tags for jj git clone and jj git remote add which mirrors the behavior of git clone and git remote add, respectively.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added/updated tests to cover my changes

@ipetkov ipetkov requested a review from a team as a code owner August 5, 2025 01:37
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me, thanks!

Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

ipetkov added 4 commits August 8, 2025 08:35
In a future commit we'll add support for controlling a git remote's tag
fetch behavior, which may result in a `tagOpt = --[no-]tags` entry in
the remote configuration.

Doing this change here means we will avoid incorrectly flagging remote
configurations as unsupported.
@ipetkov ipetkov force-pushed the push-mmtpuppuzqop branch from 620c685 to 501806c Compare August 8, 2025 15:42
@ipetkov ipetkov added this pull request to the merge queue Aug 8, 2025
@ipetkov ipetkov changed the title cli: support --[no-]tags for jj git clone and jj git remote add cli: support --fetch-tags for jj git clone and jj git remote add Aug 8, 2025
Merged via the queue into jj-vcs:main with commit dc5056a Aug 8, 2025
29 checks passed
@ipetkov ipetkov deleted the push-mmtpuppuzqop branch August 8, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants