Skip to content

lib: move git_backend tests to gitoxide #5770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

lib: move git_backend tests to gitoxide #5770

merged 1 commit into from
Feb 24, 2025

Conversation

bsdinis
Copy link
Contributor

@bsdinis bsdinis commented Feb 20, 2025

This forces some code duplication to avoid depending on the testutils.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@bsdinis
Copy link
Contributor Author

bsdinis commented Feb 20, 2025 •
edited
Loading

There is a test missing because it relies on forging signatures, which I'm not sure how to do

EDIT: Managed to get it working

@bsdinis bsdinis force-pushed the bsdinis/lzwnxytoktzm branch 2 times, most recently from 9844c19 to 274e906 Compare February 21, 2025 01:32
@bsdinis bsdinis changed the title lib: move most git_backend tests to gitoxide lib: move git_backend tests to gitoxide Feb 21, 2025
@bsdinis bsdinis force-pushed the bsdinis/lzwnxytoktzm branch from 274e906 to 4ec45c3 Compare February 21, 2025 01:49
yuja
yuja reviewed Feb 22, 2025
View reviewed changes
@bsdinis bsdinis force-pushed the bsdinis/lzwnxytoktzm branch 4 times, most recently from d11430b to c24d5c8 Compare February 24, 2025 05:42
yuja
yuja approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bsdinis bsdinis force-pushed the bsdinis/lzwnxytoktzm branch from c24d5c8 to cd28da9 Compare February 24, 2025 20:44
@bsdinis
lib: move git_backend tests to gitoxide
7f7a887 
This forces some code duplication to avoid depending on the testutils.
@bsdinis bsdinis force-pushed the bsdinis/lzwnxytoktzm branch from cd28da9 to 7f7a887 Compare February 24, 2025 20:45
@bsdinis bsdinis added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 653cc6c Feb 24, 2025
45 checks passed
@bsdinis bsdinis deleted the bsdinis/lzwnxytoktzm branch February 24, 2025 21:17
@bsdinis bsdinis mentioned this pull request Feb 21, 2025
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuja yuja yuja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsdinis @yuja