-
Notifications
You must be signed in to change notification settings - Fork 703
Closed
Labels
good first issueGood for newcomersGood for newcomers🐛bugSomething isn't workingSomething isn't working
Description
When connecting to a slow git remote over ssh I occasionally briefly see NaN%
show up. It looks like this:
$ jj git fetch --all-remotes
NaN% [
This is neither a big deal nor a real problem, but it would be nice to fix. I assume this is a result of GitProgress::to_progress()
being called with self.total() == 0
which may warrant some special casing:
Lines 624 to 630 in c5b0b0b
impl GitProgress { | |
fn to_progress(&self) -> Progress { | |
Progress { | |
bytes_downloaded: None, | |
overall: self.fraction() as f32 / self.total() as f32, | |
} | |
} |
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers🐛bugSomething isn't workingSomething isn't working