Skip to content

file deletion ignored by jj split (when using the built-in diff editor) #3702

@Zoybean

Description

@Zoybean

Description

jj split and jj squash -i both appear to ignore selected file deletions. This appears to be limited to the default editor (could not reproduce with --tool meld). They are shown in the diff editor but do not end up in the chosen commit.

Steps to Reproduce the Problem

  1. mv foo bar
  2. jj split
  3. select all changes
  4. jj show @-
  5. jj show @

Expected Behavior

the first commit contains a file addition (bar) and a file deletion (foo)
the second commit is empty

Actual Behavior

the first commit contains a file addition (bar)
the second commit contains a file deletion (foo)

Specifications

  • Platform: Windows 10
  • Version: jj 0.17.1-c34f35fffe1b8e5932ba27ac4da8ba5a97d417a5

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is neededscm-recordIssues relating to the scm-record library, used as the default interactive diff/merge editor.🐛bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions