Skip to content

Modernize CI/CD workflow, upgrade dependencies, and fix ESLint issues #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2025
Merged

Modernize CI/CD workflow, upgrade dependencies, and fix ESLint issues #25

merged 5 commits into from
Aug 25, 2025

Conversation

GoliathLabs
Copy link
Contributor

This PR modernizes the gh-actions workflows & fixes a few linting issues. I've also upgraded a few dependencies. Feel free to review :)

Changes:

  1. Dependency Upgrades

    • Updated TypeScript to 5.9.2
    • Updated ESLint to 8.57.1 (compatible with all plugins)
    • Updated @typescript-eslint plugins to 8.40.0
    • Updated runtime dependencies: dotenv, cross-env, bufferutil, utf-8-validate
    • Removed deprecated @types/dotenv

  2. Linting Fixes

    • Disabled obsolete jsdoc/newline-after-description rule
    • Fixed @typescript-eslint/no-unused-vars for unused catch parameters
    • Added explicit JSDoc types to satisfy valid-jsdoc rule

  3. CI/CD Workflow Updates

    • Unified Node.js version to 22 for CI and Release workflows
    • Added npm caching to speed up installs
    • Fixed linting glob patterns for cross-platform compatibility

@GoliathLabs GoliathLabs mentioned this pull request Aug 25, 2025
Merged
@saghul
Copy link
Member

saghul commented Aug 25, 2025

Can we drop prettier? We already have eslint-config-jitsi with the rules we like. We can use that.

@GoliathLabs
Copy link
Contributor Author

Reverted 👍🏼

saghul
saghul reviewed Aug 25, 2025
View reviewed changes
@GoliathLabs GoliathLabs requested a review from saghul August 25, 2025 12:49
@saghul saghul merged commit af4acf8 into jitsi:master Aug 25, 2025
1 check passed
@saghul
Copy link
Member

saghul commented Aug 25, 2025

Thank you!

@GoliathLabs GoliathLabs deleted the cleanup branch August 25, 2025 16:24
@GoliathLabs
Copy link
Contributor Author

@saghul we could now release the 2025.8.1 version

@saghul
Copy link
Member

saghul commented Aug 25, 2025

Sure thing, I'll get that done soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul Awaiting requested review from saghul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoliathLabs @saghul