Deepcopy handle shallow-copyable un-exported fields #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this pr? I have the same problem and the proposed solution seems reasonable to me although I am not very familiar with the codebase. |
|
hey have a look at the PR #113 it should fix the same problem and pass all tests. I've merged the PR #113 into my fork, so you could use that, until it is merged in the main project. go.mod module awesomeproject
go 1.16
require (
....
)
replace github.com/jinzhu/copier => github.com/tomdevelops/copier v0.3.3 |
|
Hm, I'm not sure how I didn't notice the test failures on my branch. Closing this in favor of #113. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #103 without special handling for
time.Time