Skip to content

Use indexes, heap-based top k for python as the other languages do #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 24, 2023
Merged

Use indexes, heap-based top k for python as the other languages do #10

merged 10 commits into from
Sep 24, 2023

Conversation

dave-andersen
Copy link
Contributor

@dave-andersen dave-andersen commented Sep 24, 2023 •
edited
Loading

8.1 -> 1.35 seconds, approximately, on M1.

@dave-andersen dave-andersen changed the title Use heap-based top-k for python to bring into parity with Rust Use indexes and heap-based top k for python as the other languages do Sep 24, 2023
@dave-andersen dave-andersen changed the title Use indexes and heap-based top k for python as the other languages do Use heap-based top k for python as the other languages do Sep 24, 2023
@dave-andersen dave-andersen changed the title Use heap-based top k for python as the other languages do Use indexes, heap-based top k for python as the other languages do Sep 24, 2023
@jinyus jinyus merged commit a9c420b into jinyus:main Sep 24, 2023
@jinyus
Copy link
Owner

jinyus commented Sep 24, 2023

Thanks, the python was neglected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dave-andersen @jinyus