feat: open pull request without close & auto refresh #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds an automatic refresh cycle for the PR list with a countdown indicator and changes the “open PR” action so the app remains open instead of quitting.
- Delegate help menus now show an
rkey with a live countdown to the next refresh. ListModelintui.gogainstickMsg/refreshCmdlogic and anextRefreshfield for periodic data reload.- Keymap updated to include a dedicated
Refreshbinding for therkey.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| main.go | Switched to pointer delegate; updated help funcs to include dynamic “r” refresh key and prevent quitting on open. |
| internal/ui/tui.go | Added tickMsg, refreshedMsg, refreshCmd, nextRefresh timing, and update logic for auto-refresh. |
| internal/ui/keymap.go | Added Refresh binding for r and ensured quit keys are registered. |
Comments suppressed due to low confidence (2)
main.go:143
- Instead of creating a new
key.Bindinginline for refresh, use the predefinedui.Keys.Refreshbinding to maintain consistency across help menus and centralize key mapping.
key.NewBinding(
internal/ui/tui.go:128
- The new auto-refresh logic (
tickMsg,refreshedMsg,refreshCmd,NextRefresh) currently has no test coverage. Adding unit tests for these cases will help prevent regressions.
func (m *ListModel) Init() tea.Cmd {
Comment on lines
+67
to
+72
| err error | ||
| wg sync.WaitGroup | ||
| ) | ||
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() |
There was a problem hiding this comment.
The shared err variable is written by multiple goroutines without synchronization, leading to a data race. Declare separate error variables inside each goroutine or send errors over a channel to avoid concurrent writes.
Suggested change
| err error | |
| wg sync.WaitGroup | |
| ) | |
| wg.Add(1) | |
| go func() { | |
| defer wg.Done() | |
| // Removed shared err variable to avoid data race. | |
| wg sync.WaitGroup | |
| ) | |
| wg.Add(1) | |
| go func() { | |
| defer wg.Done() | |
| var err error |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.