In adoption, don't remove body if adoptees malformed #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhy
added a commit
that referenced
this pull request
Aug 15, 2025
And a better guard in the adoption agency Fixes some new fuzz findings. Related to #2377.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The OSS fuzz tool found this but oddly did not make an issue for it. I only found it by reviewing the logs. Will need to dig into what wen wrong there.)
The contents of
/fuzztests/garble.htmlwould throw an IOOB when parsed. The adoption agency was trying to remove the outer body tag. So this change prevents an invalid formatting adoption attempt, to preclude that.