preserve printable unicode in protoprint #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not enough information in the descriptor to preserve the exact encoding used in the original source. So the strategy it employs is to use
unicode.IsPrintto decide if it needs to be encoded. If so, it uses an octal escape for values that fit in 7 bits, short unicode escapes for values that fit in 16 bits, and long unicode escapes for anything else.Literal values for
bytesfields use the more aggressive encoding -- any byte outside the 7-bit ASCII printable range is encoded. But, forstringfields, it will now preserve unicode in the output instead of escaping everything.Fixes #527