Skip to content

Remove dependency on grpc-go in internal/testprotos #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2022
Merged

Remove dependency on grpc-go in internal/testprotos #519

merged 3 commits into from
Jul 21, 2022

Conversation

jhump
Copy link
Owner

@jhump jhump commented Jul 21, 2022

Resolves #515

@jhump jhump mentioned this pull request Jul 21, 2022
Closed
@jhump
use newer protoc plugins (separate for normal code vs. gRPC-related c…
09c5971 
…ode); copy testprotos.TestService into DummyService in grpc sub-package, since we no longer generate gRPC stubs for testprotos; update tests to look for DummyService; fix other related errors that fall out of using new protoc grpc plugin
@jhump jhump merged commit 060cc04 into master Jul 21, 2022
@jhump jhump deleted the less-grpc-go branch July 21, 2022 21:13
@jhump
Copy link
Owner Author

jhump commented Jul 21, 2022

cc @bufdev, hopefully this does what you need. Sorry it took me so long 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep testprotos dependency on grpc-go limited to testprotos/grpc
2 participants
@jhump @bufdev