desc/builder: add FileBuilder.PruneUnusedDependencies method #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method
PruneUnusedDependencies
to a*FileBuilder
. When creating a builder from an existing file, this can be used to remove its unused imports. If the file is mutated and elements removed such that some imports are no longer necessary, this enables removing those no-longer-used imports from the built descriptor.This new method effectively removes any explicitly added imports. All imports in the built file will come from analyzing the actual referenced types in the file. Explicitly imported dependencies are typically used to provide knowledge of custom options (which cannot necessarily be found via basic examination of the builder hierarchy). But this patch preserves knowledge of custom options for descriptors created using
builder.FromFile
so thatPruneUnusedDependencies
can be safely used on these builders without resulting in inadvertently stripping custom options.Resolves #504.