Skip to content

feat: improve printing of class with long typeParameterList #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2021
Merged

feat: improve printing of class with long typeParameterList #512

merged 1 commit into from
Oct 16, 2021

Conversation

clementdessoude
Copy link
Contributor

@clementdessoude clementdessoude commented Oct 16, 2021 •
edited
Loading

What changed with this PR:

Example

// Input
public class ComplexGenericClass<BEAN extends AbstractBean & BeanItemSelect<BEANTYPE>, BEANTYPE, CONFIG extends BeanConfig<BEAN, BEANTYPE, CONFIG>> {}

// Output before the PR
public class ComplexGenericClass<BEAN extends AbstractBean & BeanItemSelect<BEANTYPE>, BEANTYPE, CONFIG extends BeanConfig<BEAN, BEANTYPE, CONFIG>> {}

// Output after the PR
public class ComplexGenericClass<
  BEAN extends AbstractBean & BeanItemSelect<BEANTYPE>,
  BEANTYPE,
  CONFIG extends BeanConfig<BEAN, BEANTYPE, CONFIG>
> {}

Relative issues or prs:

None

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $100 https://www.jhipster.tech/bug-bounties/ labels Oct 16, 2021
@pascalgrimaud
Copy link
Contributor

so nice improvement !
Adding a bounty on this

@clementdessoude clementdessoude merged commit e75133d into jhipster:main Oct 16, 2021
@clementdessoude clementdessoude deleted the feat/improve-printing-long-type-parameters-class branch October 16, 2021 08:55
@clementdessoude
Copy link
Contributor Author

Thanks @pascalgrimaud ! Bounty claimed :)

https://opencollective.com/generator-jhipster/expenses/52847

@pascalgrimaud
Copy link
Contributor

@clementdessoude : approved. Thanks so much for improving this project. For me, it is a must have in all existing Java projects

@jhaber jhaber mentioned this pull request Jan 21, 2022
Open
@jhaber jhaber mentioned this pull request Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
$$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $100 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clementdessoude @pascalgrimaud