[Suggestion] Improve tag > icon spacing #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like that idea. But how would it work with different combinations of tag size and icon size? |
|
@jgthms I've updated the codepen with further examples. The ones at the top are pretty controlled, but the bottom examples are weird mixes. I personally feel its better across the board: https://codepen.io/timacdonald/pen/qXZxwB |
|
One thing @timacdonald, unrelated. I love the big icon in the small tag, really nice effect. #steals-idea |
|
haha, yea I know right. To be honest, I was thinking, oh I should try some of these that would break things...then I was also like, "I actually really like that" haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the spacing of an icon when in a tag - similar to icon in a button.
Currently, if you have a button with an icon in it, for example:
The icon has margin applied to it to make it sit nicer and more balanced within the button. I propose doing the same thing for a tag:
It is much more subtle with a tag, but I still think its a nicer look. I duplicated the button > icon spacing and it seemed to actually work really well, so I just left it.
Tradeoffs
None I can think of.
Testing Done
Example: https://codepen.io/timacdonald/pen/qXZxwB