Remove black line from progress bar in IE #1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for inconsistent progress bar styling in IE.
Proposed solution
This PR removes the border from the
::-ms-fillpseudo-element of the progress bar. The problem and solution are discussed in this SO post: https://stackoverflow.com/questions/21780059/why-are-my-progress-bars-displaying-incorrectly-in-ieFixes #1340.
Tradeoffs
This adds one additional declaration to the build, but improves support for IE.
Testing Done
I built my branch of Bulma locally, added it to my project, and confirmed that the progress bar looks as intended.
Before fix:
After fix: