Stop is-selected row from changing color on hoverable row #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks but you need to fix your PR. It should only have a one line change. Try to rebase against master first. |
|
I've fixed the PR, thank you! Was an issue with line endings (CRLF vs LF). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix, fixing #1313.
Proposed solution
Fixes #1313, where instead of using the base active hover color for a table, will only apply that color if the table itself is not hoverable.
Tradeoffs
This doesn't show any visual difference when hovering over an row that has
is-selectedapplied to it.Testing Done
I checked the style based on the example in the documentation by adding
is-hoverableto the table demonstrating theis-selectedclass.Side note: I'm not entirely sure why git considers this entire file to be changed, I only changed line 88.