Markdown writer: preserve figure attributes #10868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
314d973 to
bf81f9a
Compare
bf81f9a to
fad45a6
Compare
|
I think you're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0d2114e introduced a bug where Markdown writer would ignore attributes on the figure if it has class or key-value attributes set.
This commit fixes that and adds a regression test.
Closes #10867
I've read over 0d2114e description and the related issue a few times, but I can't understand the motivation behind the change in
combinedAttr. So I'm just reverting that here, hopefully tests still pass. If there was some reasoning behind this -- please explain, and we can figure it out from there.