Skip to content

Conversation

cchristiansen
Copy link
Contributor

AVIF is an image extension. This commit enables the Org reader to recognise AVIF files as images to be displayed, and not simply as links.

I'm unsure whether this pull request should be merged though, as currently the default Emacs (and hence org-mode) image file name extensions are ("png" "jpeg" "jpg" "gif" "tiff" "tif" "xbm" "xpm" "pbm" "pgm" "ppm" "pnm" "svg" "webp") and do not include avif. However, AVIF is already recognised by pandoc in MIME.hs so it seems remiss to not let the Org reader recognise AVIF as an image.

AVIF is an image extension. This commit enables the Org reader to recognise
AVIF files as images to be displayed, and not simply links.
@jgm
Copy link
Owner

jgm commented Mar 29, 2025

@tarleb what do you think?
Generally we try to match Emacs behavior. On the other hand, users can modify the Emacs defaults to allow avif.

Copy link
Collaborator

@tarleb tarleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I find it hard to imagine a case where this would lead to unexpected behavior.

@jgm jgm merged commit 25253bd into jgm:main Mar 29, 2025
10 of 14 checks passed
@jgm
Copy link
Owner

jgm commented Mar 29, 2025

thanks!

massifrg pushed a commit to massifrg/pandoc that referenced this pull request May 7, 2025
AVIF is an image extension. This commit enables the Org reader to recognise
AVIF files as images to be displayed, and not simply links.
christopherkenny pushed a commit to christopherkenny/pandoc that referenced this pull request May 23, 2025
AVIF is an image extension. This commit enables the Org reader to recognise
AVIF files as images to be displayed, and not simply links.
christopherkenny pushed a commit to christopherkenny/pandoc that referenced this pull request May 23, 2025
AVIF is an image extension. This commit enables the Org reader to recognise
AVIF files as images to be displayed, and not simply links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants