Skip at most one argument to LaTeX tabular newline #10707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LaTeX's tabular environment, the tabular newline takes an optional argument that we skip. But it only takes a single optional argument, and any further square-bracketed text that follows shouldn't be skipped. Fixes jgm#7512, and also adds a test for the original problem raised in that issue which was already fixed at some point.
|
excellent, thanks |
massifrg
pushed a commit
to massifrg/pandoc
that referenced
this pull request
May 7, 2025
In LaTeX's tabular environment, the tabular newline takes an optional argument that we skip. But it only takes a single optional argument, and any further square-bracketed text that follows shouldn't be skipped. Fixes jgm#7512, and also adds a test for the original problem raised in that issue which was already fixed at some point.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
In LaTeX's tabular environment, the tabular newline takes an optional argument that we skip. But it only takes a single optional argument, and any further square-bracketed text that follows shouldn't be skipped. Fixes jgm#7512, and also adds a test for the original problem raised in that issue which was already fixed at some point.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
In LaTeX's tabular environment, the tabular newline takes an optional argument that we skip. But it only takes a single optional argument, and any further square-bracketed text that follows shouldn't be skipped. Fixes jgm#7512, and also adds a test for the original problem raised in that issue which was already fixed at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LaTeX's tabular environment, the tabular newline takes an optional argument that we skip. But it only takes a single optional argument, and any further square-bracketed text that follows shouldn't be skipped.
Fixes #7512, specifically the followup issue identified by @fedeinthemix, and also adds a test for the original problem raised in that issue which was already fixed at some point.