Docx writer: don't renumber rels (fixes #10769). #10770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced by af57648. We are now preserving the ids from the reference doc's document.xml.refs, so we shouldn't renumber them or references introduced by the user (e.g. in a template) will fail. Closes #10769.
massifrg
pushed a commit
to massifrg/pandoc
that referenced
this pull request
May 7, 2025
This fixes a regression introduced by af57648. We used to renumber the Relationships so they didn't conflict with the set of fixed Relationships we imposed. We are now preserving the ids from the reference doc's document.xml.refs, so we shouldn't renumber them or references introduced by the user (e.g. in a template) will fail. Closes jgm#10769.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
This fixes a regression introduced by af57648. We used to renumber the Relationships so they didn't conflict with the set of fixed Relationships we imposed. We are now preserving the ids from the reference doc's document.xml.refs, so we shouldn't renumber them or references introduced by the user (e.g. in a template) will fail. Closes jgm#10769.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
This fixes a regression introduced by af57648. We used to renumber the Relationships so they didn't conflict with the set of fixed Relationships we imposed. We are now preserving the ids from the reference doc's document.xml.refs, so we shouldn't renumber them or references introduced by the user (e.g. in a template) will fail. Closes jgm#10769.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by af57648.
We are now preserving the ids from the reference doc's document.xml.refs, so we shouldn't renumber them or references introduced by the user (e.g. in a template) will fail.
Closes #10769.