-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
data/templates/default.beamer: only emit \date if set #10687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one, for example, to set a custom \date in the header-includes of the rmarkdown yaml frontmatter. Without this conditional, the custom \date in the frontmatter would be overridden by a (potentially empty) date from this template later.
thanks! |
This is being reverted. The commit reverting it will include an explanation. |
jgm
added a commit
that referenced
this pull request
Mar 17, 2025
This reverts commit 3f1f58e. The reason for reverting this change is that it led to an undesirable behavior change. Documents with no explicit date specified now have a date printed, because the default title block will include a date if no `\date` command is used. The empty `\date{}`, by contrast, suppressed the date, which is the desirable behavior. PR #10687 was motivated by the desire to include a custom `\date` in the frontmatter via header-includes. I think that aim can be achieved more simply by simply setting the `date` variable. In markdown you can even use `date:` in metadata and put some raw LaTeX there.
Thank you for fixing the problem my change introduced and sorry for the extra work my PR caused. Thank you for maintaining pandoc! ❤️ |
No worries, thanks anyway for the contribution! |
massifrg
pushed a commit
to massifrg/pandoc
that referenced
this pull request
May 7, 2025
This allows one, for example, to set a custom \date in the header-includes of the rmarkdown yaml frontmatter. Without this conditional, the custom \date in the frontmatter would be overridden by a (potentially empty) date from this template later.
massifrg
pushed a commit
to massifrg/pandoc
that referenced
this pull request
May 7, 2025
This reverts commit 3f1f58e. The reason for reverting this change is that it led to an undesirable behavior change. Documents with no explicit date specified now have a date printed, because the default title block will include a date if no `\date` command is used. The empty `\date{}`, by contrast, suppressed the date, which is the desirable behavior. PR jgm#10687 was motivated by the desire to include a custom `\date` in the frontmatter via header-includes. I think that aim can be achieved more simply by simply setting the `date` variable. In markdown you can even use `date:` in metadata and put some raw LaTeX there.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
This allows one, for example, to set a custom \date in the header-includes of the rmarkdown yaml frontmatter. Without this conditional, the custom \date in the frontmatter would be overridden by a (potentially empty) date from this template later.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
This reverts commit 3f1f58e. The reason for reverting this change is that it led to an undesirable behavior change. Documents with no explicit date specified now have a date printed, because the default title block will include a date if no `\date` command is used. The empty `\date{}`, by contrast, suppressed the date, which is the desirable behavior. PR jgm#10687 was motivated by the desire to include a custom `\date` in the frontmatter via header-includes. I think that aim can be achieved more simply by simply setting the `date` variable. In markdown you can even use `date:` in metadata and put some raw LaTeX there.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
This allows one, for example, to set a custom \date in the header-includes of the rmarkdown yaml frontmatter. Without this conditional, the custom \date in the frontmatter would be overridden by a (potentially empty) date from this template later.
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
This reverts commit 3f1f58e. The reason for reverting this change is that it led to an undesirable behavior change. Documents with no explicit date specified now have a date printed, because the default title block will include a date if no `\date` command is used. The empty `\date{}`, by contrast, suppressed the date, which is the desirable behavior. PR jgm#10687 was motivated by the desire to include a custom `\date` in the frontmatter via header-includes. I think that aim can be achieved more simply by simply setting the `date` variable. In markdown you can even use `date:` in metadata and put some raw LaTeX there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one, for example, to set a custom \date in the header-includes of the rmarkdown yaml frontmatter. Without this conditional, the custom \date in the frontmatter would be overridden by a (potentially empty) date from this template later.