DOCX reader: do not issue warning for comments with ext. +styles
#10572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes jgm#10571 by also allowing `Div` as a block element
|
A different approach could be to "flatten" the style divs before checking that the content is safe. I'd assume that there are still cases where we'd want to show this warning even for Div elements. |
Like this? let paraOrPlain :: Block -> Bool
paraOrPlain (Para _) = True
paraOrPlain (Plain _) = True
paraOrPlain (Div _ nested) = (all paraOrPlain nested)
paraOrPlain _ = False |
jgm
reviewed
Jan 29, 2025
src/Text/Pandoc/Readers/Docx.hs
Outdated
| paraOrPlain _ = False | ||
| paraOrPlain (Para _) = True | ||
| paraOrPlain (Plain _) = True | ||
| paraOrPlain (Div _ nested) = (all paraOrPlain nested) |
There was a problem hiding this comment.
This is the right approach. But you don't need the () around all paraOrPlain nested.
There was a problem hiding this comment.
Adjusted the style accordingly
massifrg
pushed a commit
to massifrg/pandoc
that referenced
this pull request
May 7, 2025
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
christopherkenny
pushed a commit
to christopherkenny/pandoc
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #10571 by also allowing
Divas a block element