Skip to content

Make babel use more idiomatic #7605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

Make babel use more idiomatic #7605

merged 1 commit into from
Oct 4, 2021

Conversation

hseg
Copy link
Contributor

@hseg hseg commented Oct 3, 2021

  • Use babel's bidi implementation
  • Remove global lang option -- it broke eg hebrew
  • Import babel languages individually instead of as package options --
    was broken for greek, hebrew
  • Move header-includes to after babel setup

Closes #7604

@hseg
Make babel use more idiomatic
3d8f011 
* Use `babel`'s bidi implementation
* Remove global `lang` option -- it broke eg hebrew
* Import babel languages individually instead of as package options --
  was broken for greek, hebrew
* Move `header-includes` to after `babel` setup

Closes jgm#7604
@hseg
Copy link
Contributor Author

hseg commented Oct 3, 2021

Tested on a sample file with mixed hebrew/english text, works

@jgm jgm merged commit da8bcb7 into jgm:master Oct 4, 2021
@jgm
Copy link
Owner

jgm commented Oct 4, 2021

Thanks very much. I'll update the tests for you.

@hseg
Copy link
Contributor Author

hseg commented Oct 4, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Babel use is non-idiomatic, breaking hebrew, greek
2 participants
@hseg @jgm