This repository was archived by the owner on Feb 15, 2024. It is now read-only.
Escape all control characters #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All control characters (U+0000..U+001f) should be escaped according to RFC4627. Also escape `U+007f DELETE` - is not mentioned in RFC4627 as a control character, but it is helpful to escape it as many fonts don't render it, or weirdly.
|
Just found out that it was already attempted to handle this through |
|
Ping @jgarzik |
|
ACK |
Otherwise it's not part of 'make dist'
|
Nit fixed in 7482163 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All control characters (U+0000..U+001f) should be escaped according to RFC4627. Update gen accordingly.
Also escape
U+007f DELETE- is not mentioned in RFC4627 as a control character, but it is helpful to escape it as many fonts don't render it, or weirdly.Adds a basic roundtrip test to check escaping.