This repository was archived by the owner on Feb 15, 2024. It is now read-only.
More build fixups #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't change LDFLAGS out from under the user, they may not want a static lib. That's only needed to run tests.
Rather than always building the object regardless of the build sytem, add a manual target instead. 'make gen' will build using the system's compiler rather than the target one.
Note that it can't actually be run via Wine on the new Travis infrastructure yet. See: travis-ci/travis-ci#4171
|
|
||
| include_HEADERS = lib/univalue.h lib/univalue_escapes.h | ||
| include_HEADERS = include/univalue.h | ||
| noinst_HEADERS = lib/univalue_escapes.h |
There was a problem hiding this comment.
Private internal headers should go in foo_SOURCES AFAIK.
There was a problem hiding this comment.
That's a matter of preference. If you'd prefer it that way it's fine by me.
|
Post merge ACK. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a mingw build to Travis. See commits for details.
@jonasschnelli This fixes up your mingw issue as we discussed on IRC.