Add crosshair label padding and adjusted crosshair label position when LabelAnchor is center #414
+88
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
jfree
reviewed
May 20, 2025
| @@ -609,6 +640,9 @@ public boolean equals(Object obj) { | |||
| if (this.labelYOffset != that.labelYOffset) { | |||
| return false; | |||
| } | |||
| if (!this.labelPadding.equals(labelPadding)) { | |||
There was a problem hiding this comment.
@jfree Thank for reviewed. so will make new PR for that.
There was a problem hiding this comment.
Seen you changed. Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR I has add new crosshair label padding that draw over the
CrosshairOverlay. and adjusted crosshair label position to be within chart dataArea when LabelAnchor isCENTER. this changed apply for bothdomainCrosshairandrangeCrosshairBefore and no adjusted label position
After update and apply padding
crosshair.setLabelPadding(new RectangleInsets(3, 5, 3, 5));Please check this PR I hope this option have in this JFreeChart. or something wrong with this changed please help improve the code changed. Thank you.