Skip to content

Add OIDC context struct #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 29, 2025
Merged

Add OIDC context struct #3014

merged 9 commits into from
Jun 29, 2025

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Jun 26, 2025 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

depends on:
jfrog/jfrog-cli-core#1411
jfrog/jfrog-client-go#1140

Adds a new object -> context to oidc token params.

And populate both config and exchange command with those values.

@EyalDelarea EyalDelarea mentioned this pull request Jun 26, 2025
Merged
2 tasks
@EyalDelarea EyalDelarea marked this pull request as ready for review June 29, 2025 08:29
@EyalDelarea EyalDelarea requested a review from asafgabai June 29, 2025 08:30
@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Jun 29, 2025
@EyalDelarea EyalDelarea changed the title Add OIDC extra params Add OIDC context struct Jun 29, 2025
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Jun 29, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

asafgabai
asafgabai approved these changes Jun 29, 2025
View reviewed changes
Copy link
Contributor

@asafgabai asafgabai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EyalDelarea EyalDelarea merged commit b0db447 into jfrog:dev Jun 29, 2025
13 of 14 checks passed
naveenku-jfrog pushed a commit to naveenku-jfrog/jfrog-cli that referenced this pull request Jul 2, 2025
@EyalDelarea @naveenku-jfrog
Add OIDC context struct (jfrog#3014)
2ab5def
@BrewTestBot BrewTestBot mentioned this pull request Jul 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafgabai asafgabai asafgabai approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EyalDelarea @asafgabai