Skip to content

Fix getMajorProjectVersion Regex pattern in Go #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2024
Merged

Fix getMajorProjectVersion Regex pattern in Go #788

merged 1 commit into from
Apr 21, 2024

Conversation

dorsJfrog
Copy link
Contributor

@dorsJfrog dorsJfrog commented Apr 21, 2024 •
edited by yahavi
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 21, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Apr 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 21, 2024
@dorsJfrog
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@yahavi yahavi added the bug Create a report to help us improve label Apr 21, 2024
yahavi
yahavi approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahavi yahavi changed the title RTDEV-41633 - Fix get major project version regex pattern to get more… Fix getMajorProjectVersion Regex pattern in Go Apr 21, 2024
@yahavi yahavi merged commit c7edcaf into jfrog:master Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
bug Create a report to help us improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorsJfrog @yahavi