Fix ReadPendingException warning
#13201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReadPendingException warning
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
1fa8f47 to
8fa46e2
Compare
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
sbordet
requested changes
Jun 9, 2025
...y-client/src/main/java/org/eclipse/jetty/client/transport/internal/HttpReceiverOverHTTP.java
Outdated
Show resolved
Hide resolved
...ent/src/main/java/org/eclipse/jetty/fcgi/client/transport/internal/HttpReceiverOverFCGI.java
Outdated
Show resolved
Hide resolved
...-client-transports/src/test/java/org/eclipse/jetty/test/client/transport/HttpClientTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
sbordet
requested changes
Jun 10, 2025
...y-client/src/main/java/org/eclipse/jetty/client/transport/internal/HttpReceiverOverHTTP.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…k on client Signed-off-by: Ludovic Orban <lorban@bitronix.be>
sbordet
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that
HttpReceiverOverHTTP.parse()callsresponseSuccess()assuming that this method will queue its task into theHttpReceiver's serialized executor for later execution.Unfortunately, if
Response.Listener.onContentSource()spawns a thread that does the usual read/demand loop on the givenContent.Sourceinstance,HttpReceiverOverHTTP.parse()'s call toresponseSuccess()immediately executes the task which callsHttpReceiver.reset()before returning. This means that theContent.Source.read()call that initiated theHttpReceiverOverHTTP.parse()call does not see theEOFchunk but null, so it thinks it must demand whileresponseSuccess()already calledreceiveNext()which also did demand.Fixes #13177