Reviewed HTTP/3 API to simplify the implementation. #13181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
TODO: update the |
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
|
lorban
requested changes
May 30, 2025
...y-core/jetty-http3/jetty-http3-common/src/main/java/org/eclipse/jetty/http3/HTTP3Stream.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http3/jetty-http3-common/src/main/java/org/eclipse/jetty/http3/api/Stream.java
Outdated
Show resolved
Hide resolved
...-http3-server/src/main/java/org/eclipse/jetty/http3/server/HTTP3ServerConnectionFactory.java
Show resolved
Hide resolved
...y-http3-server/src/main/java/org/eclipse/jetty/http3/server/internal/HTTP3SessionServer.java
Show resolved
Hide resolved
| @@ -50,22 +55,20 @@ public void onRequest(HeadersFrame frame) | |||
| validateAndUpdate(EnumSet.of(FrameState.INITIAL), FrameState.HEADER); | |||
| onHeaders(frame); | |||
| updateClose(frame.isLast(), false); | |||
| listener = notifyRequest(frame); | |||
| listener = getSession().notifyRequest(frame); | |||
There was a problem hiding this comment.
Can notifyRequest() return null? Should it? I find the usage of null unclear here.
There was a problem hiding this comment.
Yes it can return null, as the listener is provided by user code.
In all the relevant places there are null checks.
...etty-http3/jetty-http3-tests/src/test/java/org/eclipse/jetty/http3/tests/DataDemandTest.java
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.