Streams: Infer Prometheus group label via Log property #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need to specify a
group
toPropulsion.Prometheus.LogSink
forPropulsion.Streams
worked, but causes two issues:This PR introduces an effectively-mandatory
"group"
Property (i.e. add it to loggers supplied to Propulsion.Streams.Projector via Serilog'slog.ForContext
) for metrics that are to be reported to Prometheus.This is an intentional breaking change for users of [Prometheus and]
Propulsion.LogSink
, but not for other usage - the Log Property requirement is optional if not using the Prometheus integration.