Prepare for ReadThrough mode #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
commented
May 18, 2023
| interface ICategory<'event, 'state, 'context> with | ||
| member _.Load(log, categoryName, streamId, streamName, allowStale, requireLeader, ct) = task { | ||
| match! tryReadCache streamName with |
There was a problem hiding this comment.
note this was not computing a correct key in the case of SlidingWindowPrefixed (fixed in #386)
nordfjord
reviewed
May 19, 2023
nordfjord
reviewed
May 19, 2023
| interface Caching.IReloadableCategory<'event, 'state, 'context> with | ||
| member _.Load(log, _categoryName, _streamId, streamName, _allowStale, requireLeader, ct) = | ||
| interface ICategory<'event, 'state, 'context> with | ||
| member _.Load(log, _categoryName, _streamId, streamName, _maxStaleness, requireLeader, ct) = |
There was a problem hiding this comment.
This is probably pragmatic, but seeing that every store implementation is ignoring the _maxStaleness parameter has me wondering if this is the right interface 🤔
There was a problem hiding this comment.
The other idea I have in that space is for the layers inward of the cache to have a LoadOrReload signature with a origin: (token*state) voption, rather than Load+Reload (should that be called Fetch ?). ICategory and ICategoryImpl ;)
nordfjord
reviewed
May 19, 2023
nordfjord
reviewed
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#386 focuses on the implementation. This PR generalises surrounding functionality in preparation for this
IReloadableinterface for the cache to interact withsupersedesstore function used to compare cache entries to acomparefunction that can also confirm an entry is identical (in order to be able to track when a cache entry has been successfully validated)allowStaleflag to be amaxStaleness: TimeSpan(true/falsebecomesTimeSpan.MaxValue/TimeSpan.Zero)CacheEntrytype internalEquinox.Core.Testsproject)